Skip to content

Delay expands duration of track#123

Merged
nixonyh merged 1 commit into
mainfrom
nixon/delay-expands-duration
Jul 23, 2026
Merged

Delay expands duration of track#123
nixonyh merged 1 commit into
mainfrom
nixon/delay-expands-duration

Conversation

@nixonyh

@nixonyh nixonyh commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Stacks on top of #122

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dd637dc4-0849-47ed-849c-4abef8514ac1

📥 Commits

Reviewing files that changed from the base of the PR and between 5a54af6 and 1a7e05a.

📒 Files selected for processing (1)
  • crates/motiongfx/src/track.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/motiongfx/src/track.rs
📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Updated delayed track behavior so fragment delays also widen the track’s duration to stay consistent with per-sequence shifting.
    • Prevented overlapping clips when chaining delayed fragments.
    • Kept final sequence end times aligned with the widened duration.
  • Tests
    • Adjusted existing delay assertions and added a regression test to verify delayed fragments chain correctly without overlaps.

Walkthrough

TrackFragment::delay now widens fragment duration using saturating arithmetic. Tests verify the updated duration and ensure delayed fragments chain without overlapping sequences.

Changes

Track fragment timing

Layer / File(s) Summary
Delay duration and chaining regression
crates/motiongfx/src/track.rs		 delay updates duration alongside sequence offsets, with tests covering the widened duration and non-overlapping chained output.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

I nudged each clip along the track,
And widened time so none slip back.
The chains now flow with room to spare,
No overlapping clips hide there.
Squeak! The ending lands just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: delaying a track fragment now expands duration.
Description check ✅ Passed The description is brief but still related to the change by noting it stacks on a dependent PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nixonyh nixonyh added the bug Something isn't working label Jul 22, 2026
@nixonyh
nixonyh force-pushed the nixon/delay-expands-duration branch from 0e37a7f to dd2e852 Compare July 22, 2026 03:25
Base automatically changed from nixon/use-duration to main July 22, 2026 15:00
@nixonyh
nixonyh force-pushed the nixon/delay-expands-duration branch from dd2e852 to 5a54af6 Compare July 23, 2026 02:24
@nixonyh
nixonyh force-pushed the nixon/delay-expands-duration branch from 5a54af6 to 1a7e05a Compare July 23, 2026 02:26
@nixonyh
nixonyh merged commit ac8e4ba into main Jul 23, 2026
8 checks passed
@nixonyh
nixonyh deleted the nixon/delay-expands-duration branch July 23, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nixonyh